-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate some old PRs WIP #39
Conversation
Replaces the Maven part of vegetable-specification-society/website#8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great. Some details to fix / consider :)
@When("^I search for \"(.*)\"$") | ||
public void search_for(String query) { | ||
WebElement element = browser.findElelment(By.name("q")); | ||
\\Enter Something to search for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single line comment in Java should be preceded by '//' not '\'
(Note: replace multiple times!)
public void checkTitle() { | ||
\\Google's search is rendered dynamically with JavaScript. | ||
\\Wait for the page to load timeout after ten seconds | ||
new WebDriverWait(driver,'10')).untill(new ExpectedCondition<Boolean> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
< and > were somehow replaced by < and >
new WebDriverWait(driver,'10')).untill(new ExpectedCondition<Boolean> { | ||
public Boolean apply(WebDriver d) { | ||
return d.getTitle().toLowerCase.startsWith("cheese"); | ||
\\Should see: "cheese! -Google Search" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert was removed?
|
||
Watir drives browsers the same way people do. It clicks links, fills in forms, presses buttons. Watir also checks results, such as whether expected text appears on the page. | ||
|
||
Watir is a family of Ruby libraries but it supports your app no matter what technology it is developed in. While Watir supports only Internet Explorer on Windows, Here comes Watir-WebDriver to solve single browser testing and support Chrome, Firefox, Internet Explorer, Opera and also running in headless mode (HTMLUnit). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app -> application(?)
what -> which(?)
some text seems to be missing (abrupt change from "IE on Windows, Here comes")
|
||
Watir is a family of Ruby libraries but it supports your app no matter what technology it is developed in. While Watir supports only Internet Explorer on Windows, Here comes Watir-WebDriver to solve single browser testing and support Chrome, Firefox, Internet Explorer, Opera and also running in headless mode (HTMLUnit). | ||
|
||
Now without wasting anytime quickly jump in to a sample UI testing program using Watir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Now without wasting anytime quickly " -> Now let's quickly
## Tips and Tricks | ||
|
||
### Multiple Browsers | ||
|
||
Cucumber can run your Scenarios with different browsers. | ||
Simply select the browser to use based on a configuration property loaded at runtime: | ||
Cucumber can run your Scenarios with different browsers, based on a configuration property loaded at runtime: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also provide java (and javascript?) examples?
content/implementations/jvm.md
Outdated
* the environment variable `MAVEN_HOME` is correctly configured. | ||
* your IDE is configured with latest maven installation. | ||
|
||
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "The" (or add whatever was here?)
content/implementations/jvm.md
Outdated
|
||
The | ||
|
||
1. Create a new maven project or fork from cucumber-java examples on github. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update groupId from info.cukes to cucumber.io
Update version to 2.0.1(?)
Closes #33