ScenarioContext.AfterStep not invoked after a failed case

[stroem]

What version of godog are you using?

Godog version is: v0.11.0

What version of Go are you using?

go version go1.15.1 darwin/amd64

What did you do?

I enabled the hooks BeforeStep and AfterStep on godog.ScenarioContext to output som logs after each step, and it worked just fine, until one step failed. After the step failed the BeforeStep was invoked but not the AfterStep.

What did you expect to see?

Either both the AfterStep and BeforeStep is invoked on following steps after a failed step or both AfterStep and BeforeStep is not invoked after a failed step.

What did you see instead?

BeforeStep was invoked for every step after a failed step, but not the AfterStep.

[lonnblad]

@stroem, thanks for the issue!

How would you prefer this, always execute the hooks, even on skipped steps or not execute them?
If we would execute the hooks, would you like to have some form indication that this step won't be executed?

BR Fredrik

[fgm]

I think it is safer to have them execute always, using the test status if desired to act differently depending on success, failure or being skipped.

[lonnblad]

@fgm, Thanks for your feedback!
How do you see this status being propagated to the hook or is it up to the user to keep this information from the last AfterStep-hook?

[fgm]

Haven't look in detail, but I think the info is already present on the PickleStep passed to the hook, is it not ?

[lonnblad]

@fgm I don't think so, we only pass the parsed Step information as of now.

I propose doing like this, change so that we execute the AfterStep as well and keep the BeforeStep as is, so we make it consistent and then have another discussion on how we can indicate that a specific step won't be executed or if we should skip the hooks completely.

The discussion (#360) about adding context to the step execution might also be a good topic to take up this issue in a future solution.