Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r# strings in rust #176

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

kieran-ryan
Copy link
Sponsor Member

@kieran-ryan kieran-ryan commented Jan 7, 2024

🤔 What's changed?

Check for 'r#' strings in Rust and exclude elements exclude all elements except for the string content itself.

⚡️ What's your motivation?

Fixes cucumber/vscode#202.

Raw strings in Rust of the format r"" are currently supported. However, r#""# raw strings are unsupported.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@kieran-ryan kieran-ryan self-assigned this Jan 7, 2024
@kieran-ryan kieran-ryan added the 🐛 bug Defect / Bug label Jan 7, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review January 7, 2024 21:45
Copy link
Contributor

@GoooIce GoooIce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :D

@kieran-ryan kieran-ryan merged commit 42bb67a into cucumber:main Jan 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension can not find step files in rust project
2 participants