-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failures on older Perl versions #15
Conversation
Although List::Util is a core module (better: it's dual life), it only grew support for 'any' and 'all' in 1.33, which doesn't come with some of the older Perl versions. Specifying the number explicitly makes older Perls install this module from CPAN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
We have to find out why the python build is failing on macos, but maybe that could be part of another PR?
@aurelien-reeves The problem with python/macOS seems to an OOPS in the BACKGROUND: SEE ALSO: |
5.0.0 (2023-01-02) Added * [JavaScript] Support for EcmaScript modules (aka ESM). (#5) * [Java] Enabled reproducible builds Changed * Only allow escape character \ in front of (, ), \ or whitespace. Throw error otherwise. (#17) Fixed * [Perl] Fixed missing dependency as well as new syntax in the tests (cucumber/tag-expressions#15 ehuelsmann) * Document escaping. (#16, #17) * [Ruby], [Perl] Empty expression evaluates to true * [Go] Fix module name (#82) 5.0.1 (2023-01-03) Fixed * [Java] Fix scm and project urls 5.0.2 (2023-07-15) Added * [Python] Make tests pass against shared test data (except: backslash-escaped) (#18 by jenisys) Fixed * [All] Not.to_string() conversion has unneeded double-parenthesis if binary operator is contained (#94 by jenisys) 5.0.3 (2023-08-10) Fixed * [Perl] Fixed CPAN upload in release process (by ehuelsmann) 5.0.4 (2023-08-10) Fixed * [Perl] Corrected working directory for CPAN upload action (by ehuelsmann) 5.0.5 (2023-08-11) Fixed * [Perl] Fixed inclusion of CHANGELOG.md causing release to fail (by ehuelsmann) 5.0.6 (2023-08-13) Fixed * [Perl] Fixed test failures when running tests out-of-tree by resticting testdata based tests to run in development only (by ehuelsmann) 6.0.0 (2023-10-13) Added * [Ruby] Initial rubocop gems and basic compliance added (More work to come) (#133) Changed * [Ruby] Minimum ruby version is now bumped from 1.9 to 2.3 (#133) Fixed * [Perl] Include README.md and LICENSE in the release tarball (by ehuelsmann)
Description
Address most -if not all- failures on http://matrix.cpantesters.org/?dist=Cucumber-TagExpressions+4.1.0
Motivation & context
The module declares a minimum Perl version of 5.14 which is true, on code level, but to make it true for the distribution, it needs to declare its dependencies better. Also, for the tests to succeed, the syntax needed to be downgraded.
Type of change
Checklist: