Close NamedTemporaryFile early for Windows compat #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. Running
python manage.py assets build
orwatch
causes the following error on Windows:The problem comes from Python's
tempfile.NamedTemporaryFile
. As long as the file is not closed in Python, it can't be accessed by external processes on Windows. You can read about that here:https://bugs.python.org/issue14243
and in the
tempfile
documentation:https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile
The solution is just to create the temp file with
detete=False
, close it immediately, and delete it manually when it's not used anymore.webassets.filter.ExternalTool.subprocess
itself uses a similar approach, only withtempfile.mkstemp
instead.