Skip to content

Commit

Permalink
ci: fix job dependency in test workflow
Browse files Browse the repository at this point in the history
The main build matrix does not currently depend on the start job. Hence
the build matrix starts in parallel with the start job (the latter is
responsible for notifying the start of a build). Which means the start
message can get delayed.

Fix that.

Change-Id: Ia7710fd3762ab8656df8cd82dcaee198a7e91c83
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8401
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
  • Loading branch information
myitcv committed Jan 29, 2021
1 parent 3088513 commit 34333ce
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
github.run_id }}"}'' -b ~/.gitcookies https://cue-review.googlesource.com/a/changes/$(basename
$(dirname $GITHUB_REF))/revisions/$(basename $GITHUB_REF)/review'
test:
needs: start
strategy:
fail-fast: false
matrix:
Expand Down
1 change: 1 addition & 0 deletions internal/ci/workflows.cue
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ test: _#bashWorkflow & {
]
}
test: {
needs: "start"
strategy: _#testStrategy
"runs-on": "${{ matrix.os }}"
steps: [
Expand Down

0 comments on commit 34333ce

Please sign in to comment.