evaluator: closedness not applied to optional field

[myitcv]

What version of CUE are you using (cue version)?

$ cue version
cue version v0.0.0-20220801114602-5a08d2f7a9a7

       -compiler gc
     CGO_ENABLED 1
          GOARCH arm64
            GOOS linux
             vcs git
    vcs.revision 5a08d2f7a9a7595def05c5486cbb5276e66391cb
        vcs.time 2022-08-01T11:46:02Z
    vcs.modified false

Does this issue reproduce with the latest release?

Yes

What did you do?

! exec cue eval .
stderr 'x1.age1: field not allowed'
stderr 'x2.age2: field not allowed'

-- x.cue --
package x

#x: {
	y: {
		z?: {
			name: string
		}
	}
}

egs: {
	x1: (#x & {y: z: _}).y.z & {
		name: "blah"
		age1: 5
	}
	x2: (#x.y & {z: _}).z & {
		name: "blah"
		age2: 5
	}
}

What did you expect to see?

Test to pass

What did you see instead?

> ! exec cue eval .
[stdout]
#x: {
    y: {}
}
egs: {
    x1: {
        name: "blah"
        age1: 5
    }
    x2: {
        name: "blah"
        age2: 5
    }
}
FAIL: /tmp/testscript2385917320/repro.txt/script.txt:1: unexpected command success

What's interesting is that the following succeeds, as expected:

exec cue def x.cue --inline-imports -e egs -o out.cue
cmp out.cue out.cue.golden
! exec cue eval out.cue
stderr 'x1.age1: field not allowed'
stderr 'x2.age2: field not allowed'

-- x.cue --
package x

#x: {
	y: {
		z?: {
			name: string
		}
	}
}

egs: {
	x1: (#x & {y: z: _}).y.z & {
		name: "blah"
		age1: 5
	}
	x2: (#x.y & {z: _}).z & {
		name: "blah"
		age2: 5
	}
}
-- out.cue.golden --
x1: Z.#x & {
	name: "blah"
	age1: 5
}
x2: Z_1.#x & {
	name: "blah"
	age2: 5
}

//cue:path: y.z
let Z = {
	#x: {
		name: string
	}
}

//cue:path: z
let Z_1 = {
	#x: {
		name: string
	}
}

[mvdan]

This is another one that's fixed in the new evaluator :) It tracks closedness in a different way, so that must have fixed this bug. Regression test incoming.