-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update go version for release #1223
Conversation
The yaml files are generated from CUE https://github.com/cue-lang/cue/blob/master/internal/ci/workflows.cue Not sure if it is worth updating the workflow schema (via |
@myitcv can releases be built with the latest Go version while still maintaining the two supported Go version parity? Go 1.17 added |
@hrvolapeter welcome to the CUE project! We tend to prefer raising issues in the first instance to help flesh out the detail of any change. Not least because an issue might actually give rise to a number of changes, hence the issue and discussion will outlive one of those changes. There are a few things we probably want to address here:
Is there anything I'm missing from the list above?
@verdverm we used to build with the latest version of Go. Looks like when I updated our build matrix from |
@myitcv another update in 1.17 I was thinking might be helpful for API users is the dependency pruning. That would require updating the Go directive in Another thought, is there preference for including (or not) the patch version in the workflows? (i.e. (adding here until there is a discussion issue created) |
I've created an issue with the summary of points discussed here. #1225 |
Signed-off-by: Peter Hrvola <peter.hrvola@gmail.com>
@myitcv I've added changes for 1. in #1225
|
Go since version 1.16 supports darwin/amd64 and go-releaser supports this target from v0.156.0 so as far as I can tell this is the only change needed to support darwin/amd64 target