Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overpass query parameters should show up in popup #185

Closed
mapsam opened this issue Oct 12, 2015 · 4 comments
Closed

overpass query parameters should show up in popup #185

mapsam opened this issue Oct 12, 2015 · 4 comments
Labels
bug

Comments

@mapsam
Copy link
Member

mapsam commented Oct 12, 2015

Right now the popup shows tags as an [object Object] instead of actually listing them.
@mapsam mapsam added the bug label Oct 12, 2015
@mapsam
Copy link
Member Author

mapsam commented Oct 12, 2015

screen shot 2015-10-12 at 11 05 14 am

seems okay to loop through these specifically and create new attributes named tag_NAME

mapsam added a commit that referenced this issue Oct 12, 2015
@mapsam
Merge pull request #186 from cugos/overpass-tag-attributes
52ed848 
creates tag_ properties for overpass tag object, fixes #185
@mapsam
Copy link
Member Author

mapsam commented Oct 14, 2015

This is fixed in 0.1.1

@tyrasd
Copy link
Contributor

tyrasd commented Oct 15, 2015

Btw: osmtogeojson has a flatProperties option which would also result in a similar, flat structure.

mapsam added a commit that referenced this issue Oct 15, 2015
@mapsam
use flatProperties:true from osmtogeojson, thanks @tyrasd, resolves #185
099f6da
@mapsam
Copy link
Member Author

mapsam commented Oct 15, 2015

Hey! That's a lot easier. Thanks for pointing that out. Just removed our own function and set the options. Should be out in 0.1.1

@mapsam mapsam mentioned this issue Oct 20, 2015
Merged
@mapsam mapsam closed this as completed in c4560ee Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tyrasd @mapsam