Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need test suite #22

Closed
alukach opened this issue Apr 4, 2015 · 1 comment
Closed

Need test suite #22

alukach opened this issue Apr 4, 2015 · 1 comment
Labels
task

Comments

@alukach
Copy link
Member

alukach commented Apr 4, 2015

As the project grows and code changes, it is important to have a set of unit tests ensuring that the system runs as expected.

I am not well versed in JS unit tests, can anyone offer suggestions as to how we should do this? tape seems popular.
@alukach alukach added the task label Apr 4, 2015
@alukach alukach mentioned this issue Apr 4, 2015
Closed
ranchodeluxe added a commit that referenced this issue Apr 4, 2015
@ranchodeluxe
start dron-n-chop rewrite as Leaflet subclasses
cdf4334 
this is an example that takes an existing drop-n-chop "component"
and creates a DropZone Leaflet subclass with a FileReader
handle which delegates events for the map's drag-n-drop options.

I think it would be nice if the other drop-n-chop "components" were
also written as Leaflet extensions/subclasses.

For example:

- The FileLayerList could extend L.Control.Layers as this extensions
does >
https://github.com/stefanocudini/leaflet-panel-layers/blob/master/src/leaflet-panel-layers.js

- The GeoMenu could extend L.Control to create the dropdown toolbar

There would still be a drop-n-chop module that wraps the mapping needs
and also has refs to the above components as this commit shows with
L.DNC.DropZone.FileReader

regarding discussion in #8, we then don't need browserify at all.
regarding issues ( #22, #23 ), tests will be easier to write
when we come to an agreement on the structure
@alukach alukach mentioned this issue Apr 15, 2015
Closed
@alukach
Copy link
Member Author

alukach commented May 13, 2015

While not perfect, I feel that #79 has gotten us started with this.

@alukach alukach closed this as completed May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alukach