Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix travis tests #257

Merged
merged 6 commits into from
Jul 30, 2016
Merged

fix travis tests #257

merged 6 commits into from
Jul 30, 2016

Conversation

mapsam
Copy link
Member

@mapsam mapsam commented Jul 30, 2016

Working on fixing the tests in travis - currently running into Maximum call stack size exceeded errors during our vendor script, which takes a long time.

@mapsam
Copy link
Member Author

mapsam commented Jul 30, 2016

Huzzah! Removing our custom mapbox.js bundle and just going straight to the CDN has improved travis speeds immensely. @wboykinm @SwampGuzzler

Unfortunately, the topojson client is a bit different these days and an attempt at babelifying it doesn't result in code that works in browser, and still tries to fs.readFileSync. I've copied over our current topojson_package.js in the lib/ so we can continue to use it until we can dig further. cc @jczaplew

TODO:

@mapsam
Copy link
Member Author

mapsam commented Jul 30, 2016

Ah, just a path change needed for topojson - thanks @SwampGuzzler!

@mapsam
Copy link
Member Author

mapsam commented Jul 30, 2016

Woo! This is good to go.

@mapsam mapsam merged commit 0bbd476 into master Jul 30, 2016
@mapsam mapsam mentioned this pull request Jul 30, 2016
@mapsam mapsam deleted the fix-tests branch July 30, 2016 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants