Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js! plugin is broken without !order #20

Closed
samuelvogel opened this issue Sep 7, 2011 · 2 comments
Closed

js! plugin is broken without !order #20

samuelvogel opened this issue Sep 7, 2011 · 2 comments
Assignees
@unscriptable
Milestone
0.5.3

Comments

@samuelvogel
Copy link

Review the following code:

<!doctype html>
<html lang="en">
<head>
    <script src="js/curl-0.5.2.js"></script>
    <script>
        curl(['js!js/jquery-1.6.2.js'], function() {
                $('body').text('loaded');
            });
    </script>
</head>
<body>

</body>
</html>

Curl tries to load jQuery from / for some reason. Adding !order to the jQuery load fixes this. But according to the doc of the js! plugin !order is optional.
@ghost ghost assigned unscriptable Sep 7, 2011
@unscriptable
Copy link
Member

Interesting. I'll set up a test case for this to find out what's happening.

@unscriptable
Copy link
Member

Hello @samuelvogel, thanks for finding this. It was introduced in 0.5.2. It's patched in the dev branch and will be put into the master branch in rev 0.5.3. -- J

unscriptable pushed a commit that referenced this issue Sep 24, 2011
test for issue #20
feb2c12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unscriptable unscriptable

Labels
None yet
Projects
None yet
Milestone
0.5.3
Development

No branches or pull requests
2 participants
@unscriptable @samuelvogel