Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of finer grained dojo 1.7 modules in wire/dojo/* plugins #22

Open
briancavalier opened this issue Feb 16, 2012 · 4 comments

Comments

@briancavalier
Copy link
Member

Spurred on by info from @neonstalwart in this thread, we should revisit all the dojo plugins and update the dependencies to take advantage of the new finer grained modules in dojo 1.7.

@unscriptable
Copy link
Member

Ben is right in his comment: #21 (comment) The dojo modules and their locations has significantly changed from 1.6 to 1.7.

We'll have to be careful that we don't break compatibility with dojo 1.6, or else we'll have to declare that wire 0.x+ requires dojo 1.7.

@neonstalwart
Copy link

hence my comment that it's more like supporting 2 libraries rather than 2 versions of the same library. in my opinion, they're not nearly compatible enough to support both as "dojo". you'd need to have specific "dojo16" plugins for just dojo 1.6 and then i'd suggest "dojo" would be for dojo 1.7+ or as @unscriptable says - declare that dojo 1.7 is the minimum you support.

@briancavalier
Copy link
Member Author

That sounds good to me. I like the idea of providing dojo 1.6 and dojo 1.7 variants of the current wire/dojo/* plugins. We can let people know that all new dojo plugin dev will be for 1.7+. We can probably copy the existing plugins to a "wire/dojo16" dir, and then dojo 1.6 users can configure their loader to point wire/dojo to wire/dojo16 and not have to modify any of their wire specs.

@briancavalier
Copy link
Member Author

I'm scheduling this for v0.9.0 for now. I'm not sure if we'll make it, but we'll try. If not, we'll include it in a v0.9.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants