Ignoring Metrics/BlockLength for specs #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the do/end block that encompasses the entire spec file gets long and often fails this cop. Generally, we want to encourage having more tests, not less and this can cop can sometimes get in the way.
cgalarza
requested review from
barmintor,
JackBlackLight,
elohanlon and
fcd1
barmintor
approved these changes
Nov 25, 2019
elohanlon
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the do/end block that encompasses the entire spec file gets long and often fails this cop. Generally, we want to encourage having more tests, not less and this can cop can sometimes get in the way.