Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for input types to getArgs #435

Merged
merged 3 commits into from
Dec 9, 2021
Merged

fix: add support for input types to getArgs #435

merged 3 commits into from
Dec 9, 2021

Conversation

smeijer
Copy link
Contributor

@smeijer smeijer commented Aug 13, 2020

fixes #434

@smeijer
Copy link
Contributor Author

smeijer commented Aug 13, 2020

Someone might want to extend this, and add support for nested input types as well. This can "easily" be done adding some recursion to my change.

@smeijer
Copy link
Contributor Author

smeijer commented Aug 13, 2020

Made it recursive as well.

@smeijer smeijer changed the title fix: add support for input types fix: add support for input types to getArgs Aug 13, 2020

return args.reduce((acc, field) => {
acc[field.name.value] =
field.value.kind === 'ObjectValue'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a descriptive comment for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Sorry for the delay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theodorDiaconu, does the added comment work for you?

@theodorDiaconu theodorDiaconu merged commit a2b2e6b into cult-of-coders:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getArgs doesn't work for input types
2 participants