Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedShiftComplexDataTypeTransformer - Added Kafka Metadata fields #55

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

shraddha-ca
Copy link
Contributor

@shraddha-ca shraddha-ca commented Apr 24, 2024

Context

https://cultureamp.atlassian.net/browse/TDPR-126

Implementation

  • Adding Kafka metadata fields _kafka_metadata_partition, _kafka_metadata_offset and _kafka_metadata_timestamp to map to record.kafkaPartition(), record.kafkaOffset(), record.timestamp() respectively.
  • Version upgrade in build.gradle.kts

Testing

  • Updated unit tests: src/test/kotlin/com/cultureamp/kafka/connect/plugins/transforms/RedShiftComplexDataTypeTransformerTest.kt and schema src/test/resources/com/cultureamp/employee-data.employees-v1-target-schema.avsc
  • Testing with kafka-ops Data Lake Connectors: https://github.com/cultureamp/kafka-ops/pull/1571, columns created and populated as per screenshot
image

@shraddha-ca shraddha-ca changed the title added fields and unit tests RedShiftComplexDataTypeTransformer - Added Kafka Metadata fields Apr 24, 2024
@shraddha-ca shraddha-ca marked this pull request as ready for review April 24, 2024 03:45
@shraddha-ca shraddha-ca requested a review from a team as a code owner April 24, 2024 03:45
Copy link
Contributor

@amatueva amatueva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amatueva amatueva merged commit 4da5dc4 into main Apr 24, 2024
1 check passed
@amatueva amatueva deleted the TDPR-126/adding-kafka-metadata-fields branch April 24, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants