Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update react-date-picker and date-fns #4449

Merged
merged 8 commits into from
Jan 18, 2024

Conversation

cultureamp-renovate[bot]
Copy link
Contributor

@cultureamp-renovate cultureamp-renovate bot commented Dec 24, 2023

What

KZN-2035

  • Update date-fns
  • Update react-day-picker
  • Add import statements for Locale from date-fns
  • Update test selectors to work with react-day-picker changes
    • Days have changed from "button" to "gridcell" with a name of just the date (eg. "1st February (Tuesday)" is now "1")
    • Add extra selector to check the month (since it is now missing from the day's accessible name)
    • aria-pressed is now aria-selected
  • Add accessible name to Filter dialog
    • Updated FilterBar Filter components to pass id through
  • Ignore a11y rule aria-allowed-role for calendar days (see Notes)

Notes

We are aware that the update includes broken a11y behaviour from the library (gpbl/react-day-picker#1688), but we have opted to prevent lagging behind version updates instead. Hopefully it will be fixed/not be called out as a huge issue by the next audit.

Copy link

changeset-bot bot commented Dec 24, 2023

🦋 Changeset detected

Latest commit: 5b71d3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kaizen/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from renovate/rollup to main January 3, 2024 03:28
@cultureamp-renovate
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@HeartSquared HeartSquared force-pushed the renovate/update/date-fns-3.x branch 3 times, most recently from 2cccbbf to 1b584da Compare January 16, 2024 06:22
@HeartSquared HeartSquared marked this pull request as ready for review January 17, 2024 02:34
@HeartSquared HeartSquared requested a review from a team as a code owner January 17, 2024 02:34
@HeartSquared HeartSquared changed the title fix(deps): update dependency date-fns to v3 fix: update react-date-picker and date-fns Jan 17, 2024
Copy link
Contributor

github-actions bot commented Jan 17, 2024

✨ Here is your branch preview! ✨

Last updated for commit 5b71d3b: test: fix date-picker tests in stories

@HeartSquared HeartSquared merged commit add4a75 into main Jan 18, 2024
17 checks passed
@HeartSquared HeartSquared deleted the renovate/update/date-fns-3.x branch January 18, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants