Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_dart_signal_receiver return Result #380

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Conversation

temeddix
Copy link
Member

Changes

This PR completely removes unwrap and expect from the codebase. As a consequence, get_dart_signal_receiver returns Result.

Before Committing

Please make sure that you've analyzed and formatted the files.

dart analyze flutter_ffi_plugin --fatal-infos
dart format .
cargo fmt
cargo clippy --fix --allow-dirty

@temeddix temeddix changed the title No unwrap or expect No unwrap or expect Jun 17, 2024
@temeddix temeddix changed the title No unwrap or expect Make get_dart_signal_receiver return Result Jun 17, 2024
@temeddix temeddix merged commit c16674e into main Jun 17, 2024
15 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant