Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move stream to cupy_backends #3584

Closed
wants to merge 3 commits into from
Closed

Move stream to cupy_backends #3584

wants to merge 3 commits into from

Conversation

okuta
Copy link
Member

@okuta okuta commented Jul 9, 2020 •
edited
Loading

This PR relates #3385 and #3386.
This PR relates #3597 .

@leofang
Copy link
Member

leofang commented Jul 9, 2020

Sorry, I think I didn't get the point 😅 Why is cupy/cuda/stream.pyx removed instead of cupy_backends/cuda/stream.pyx? I thought you wanna keep CuPy's wrappers (in this case, Stream and Event) in the cupy.cuda namespace?

@leofang leofang mentioned this pull request Jul 10, 2020
Merged
This was referenced Jul 13, 2020
Closed
Open
@kmaehashi kmaehashi changed the title Mvoe stream Move stream Jul 13, 2020
@kmaehashi kmaehashi changed the title Move stream Move stream to `cupy_backends Jul 13, 2020
@kmaehashi kmaehashi changed the title Move stream to `cupy_backends Move stream to cupy_backends Jul 13, 2020
@emcastillo
Copy link
Member

I think the same as @leofang 😅

@kmaehashi kmaehashi added this to the v8.0.0rc1 milestone Jul 15, 2020
@asi1024 asi1024 removed this from the v8.0.0b5 milestone Jul 29, 2020
@leofang leofang mentioned this pull request Nov 25, 2020
Merged
@leofang leofang mentioned this pull request Dec 16, 2020
Closed
@kmaehashi
Copy link
Member

We discussed this today and the team is thinking that it's better to keep the current implementation. #4445 (comment)

@kmaehashi kmaehashi closed this Dec 17, 2020
@asi1024 asi1024 added this to the Closed PRs milestone Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emcastillo emcastillo

Labels
None yet
Projects
None yet
Milestone
Closed PRs
Development

Successfully merging this pull request may close these issues.
5 participants
@okuta @leofang @emcastillo @kmaehashi @asi1024