-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project structure improvements #185
Conversation
This pull request is being automatically deployed with Vercel (learn more). frontend – ./examples/frontend🔍 Inspect: https://vercel.com/curaos/frontend/YGPjotTXC9iPVTb1uhNCdRPG2f1a frontend-dev – ./🔍 Inspect: https://vercel.com/testtete/frontend-dev/3VA9HyaR6UawE9SmeZZmLjSVDAbp |
Hey @AshenI99, can you test this changes if they work fine for you? Just checkout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the review status.
-
yarn dev:frontend : working perfectly. Changes made to the hooks and components are appearing instantly without any issue.
-
yarn dev:components : working perfectly. Changes made to the hooks and components are appearing instantly without any issue.
-
yarn build:components : working perfectly. Building the components/dist folder without any issue
-
yarn build:hooks : working perfectly. Building the hooks/dist folder without any issue
-
yarn build:frontend : getting the below issue.
Everything working perfectly except yarn build:frontend.
Great Job!💯 This will make the coding process more easier. 🙂👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid! A lot of minor and major version changes so let's make sure nothing breaks, which doesn't seem to at first look. I have a few doubts that I commented on, other than that thanks for taking this on and carrying it over the finish line!
Had to install |
🎉 This PR is included in version @cura/hooks-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version @cura/components-v1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
I upgraded
Yarn
to version 3 because it offers some helpful features such as workspace ranges and release workflow which we can use to automate the publishing of packagesNow using
yalc
for developement is unnecessary, because the frontend is resolving the local packages automatically from the workspace.Upgraded to
NextJs 12
because it's fast and cool. And it allows us to have hot reloading without needingnext-transpile-modules
thanks to externalDirAlso, I fixed all eslint errors which were filling the console log and causing vscode to show errors
And, optimized images from the homepage to make them load a bit faster
And to make it easy for developers, there is a new set of commands that we can call anywhere from the project folder. (Also added them to README)
This PR will make it helpful to move on with #120 and #114
Note
This update require some changes to Vercel settings, as following: