Adds URLs to ETD show page, and degree awarded notification. #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
reviewed
Apr 4, 2018
app/views/hyrax/base/show.html.erb
Outdated
| @@ -5,7 +5,9 @@ | |||
| <%= render 'work_title', presenter: @presenter %> | |||
| </header> | |||
|
|
|||
| <span>Permanent URL: <%= Rails.application.routes.url_helpers.send(@presenter.model_name.singular_route_key + '_url', @presenter.id) %></span> | |||
There was a problem hiding this comment.
Why do we need to do #send here? Don't we have access to the url_helpers natively in the view?
There was a problem hiding this comment.
That was the idiom I saw in the code base (https://github.com/curationexperts/laevigata/blob/master/app/services/hyrax/workflow/laevigata_notification.rb#L21). Rails.application.routes.url_helpers.hyrax_etd_url(@presenter) also works, but hyrax_etd_url(@presenter), and url_for(@presenter) do not.
There was a problem hiding this comment.
Is the right thing main_app.etd_url(...)?
If not, we should probably at least do public_send instead of send. :)
|
New after screenshot, includes language in the URL: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tests, as these are in views, although I'm happy to add them.
Here's a before:
And after:
