Some implementations and changes

[roubachof]

For our projects, we added some PCL fake, Xamarin implementations, and changed a bit things (created TypeForwarding.Xamarin in Net.Shim to split supported type in Xamarin AND NETFX from supported type in NETFX).
I don't know if it fits the philosophy of your shim :)

[anders9ustafsson]

Many thanks for helping out! I will review this as soon as possible.

Best regards,
Anders @ Cureos

Sent from my iPhone

On 5 feb. 2016, at 11:34, Roubachof notifications@github.com wrote:

For our projects, we added some PCL fake, Xamarin implementations, and changed a bit things (created TypeForwarding.Xamarin in Net.Shim to split supported type in Xamarin AND NETFX from supported type in NETFX).
I don't know if it fits the philosophy of your shim :)

You can view, comment on, or merge this pull request online at:

#36

Commit Summary

New Shim.Xamarin shared project for shim implementation for Xamarin projects.
Merge branch 'development' of https://github.com/cureos/shim into development
sln version updated
File Changes

M Sources/Shim.sln (107)
A Sources/Shim/ComponentModel/IContainer.cs (6)
A Sources/Shim/ComponentModel/ITypeDescriptorContext.cs (15)
A Sources/Shim/ComponentModel/MemberDescriptor.cs (6)
A Sources/Shim/ComponentModel/PropertyDescriptor.cs (6)
A Sources/Shim/ComponentModel/TypeConverter.cs (361)
A Sources/Shim/Data/DataSet.cs (20)
A Sources/Shim/Diagnostics/ExcludeFromCodeCoverageAttribute.cs (9)
A Sources/Shim/IServiceProvider.cs (7)
A Sources/Shim/ServiceModel/CallbackBehaviorAttribute.cs (67)
A Sources/Shim/ServiceModel/ConcurrencyMode.cs (11)
A Sources/Shim/Transactions/IsolationLevel.cs (13)
A Sources/Shim/Windows/Point.cs (40)
M Sources/Shim/_Droid/Droid.Shim.csproj (5)
M Sources/Shim/_Net/Net.Shim.csproj (3)
M Sources/Shim/_Net/TypeForwarding.Net.cs (187)
A Sources/Shim/_Net/TypeForwarding.Xamarin.cs (192)
M Sources/Shim/_Profile111/Portable111.Shim.csproj (33)
M Sources/Shim/_Touch/Touch.Shim.csproj (5)
M Sources/Shim/_Unified/Unified.Shim.csproj (5)
A Sources/Shim/_Xamarin/Diagnostics/ExcludeFromCodeCoverageAttribute.cs (9)
A Sources/Shim/_Xamarin/ServiceModel/CallbackBehaviorAttribute.cs (29)
A Sources/Shim/_Xamarin/ServiceModel/ConcurrencyMode.cs (11)
A Sources/Shim/_Xamarin/Shim.Xamarin.projitems (17)
A Sources/Shim/_Xamarin/Shim.Xamarin.shproj (13)
A Sources/Shim/_Xamarin/Windows/Point.cs (34)
Patch Links:

https://github.com/cureos/shim/pull/36.patch
https://github.com/cureos/shim/pull/36.diff
—
Reply to this email directly or view it on GitHub.

[anders9ustafsson]

@roubachof There are several code parts that seem relevant to add to Shim in your PR, many thanks! But what is the specific reason for adding the Xamarin "project"?

[roubachof]

@anders9ustafsson well the Xamarin project is an implementation of missing namespace in Xamarin. You can see that I splitted TypeForwarding.Net.cs into TypeForwarding.Net.cs and TypeForwarding.Xamarin.cs. TypeForwarding.Xamarin.cs contains all namespaces that are available in Xamarin AND NetFx. TypeForwarding.Net.cs contains namespaces available only in NetFx. So the Xamarin project give a basic implementation of those missing namespaces so projects will work in Xamarin targets. Doing that, I don't know if it complies to the philosophy of your lib, so merge what you want :)

[anders9ustafsson]

@roubachof Many thanks for sharing, and sorry I have not looked at this closely before.

Unfortunately, it its current form I am reluctant to pull this request, since it spans over too much at the same time, it violates some design ideas for Shim (for example, I don't want to include any graphics related types like Point), and the API documentation is almost entirely missing.

So I am going to close this PR now, but feel free to re-post in smaller dedicated chunks so that it is possible to have a discussion on each part separately before accepting contributed code.

Regards,
Anders @ Cureos