-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some implementations and changes #36
Conversation
…rojects. Renamed TypeForwarding.Net in Net.Shim project to TypeForwaring.Xamarin since it is shared with Xamarin targets. Added: * Dataset in Profile 111, type forwarded in Xamarin * ComponentModel.TypeConverter in Profile 111, type forwarded in Xamatin * ExcludeFromCodeCoverageAttribute in Profile 111, implemented in Xamarin * CallbackBehaviorAttribute in Profile 111, implemented in Xamarin * Windows.Point in Profile 111, implemented in Xamarin
Many thanks for helping out! I will review this as soon as possible. Best regards, Sent from my iPhone
|
…ethods. Fix missing TypeForward in TypeForwarding.Xamarin.cs
@roubachof There are several code parts that seem relevant to add to Shim in your PR, many thanks! But what is the specific reason for adding the Xamarin "project"? |
@anders9ustafsson well the Xamarin project is an implementation of missing namespace in Xamarin. You can see that I splitted TypeForwarding.Net.cs into TypeForwarding.Net.cs and TypeForwarding.Xamarin.cs. TypeForwarding.Xamarin.cs contains all namespaces that are available in Xamarin AND NetFx. TypeForwarding.Net.cs contains namespaces available only in NetFx. So the Xamarin project give a basic implementation of those missing namespaces so projects will work in Xamarin targets. Doing that, I don't know if it complies to the philosophy of your lib, so merge what you want :) |
@roubachof Many thanks for sharing, and sorry I have not looked at this closely before. Unfortunately, it its current form I am reluctant to pull this request, since it spans over too much at the same time, it violates some design ideas for Shim (for example, I don't want to include any graphics related types like So I am going to close this PR now, but feel free to re-post in smaller dedicated chunks so that it is possible to have a discussion on each part separately before accepting contributed code. Regards, |
For our projects, we added some PCL fake, Xamarin implementations, and changed a bit things (created TypeForwarding.Xamarin in Net.Shim to split supported type in Xamarin AND NETFX from supported type in NETFX).
I don't know if it fits the philosophy of your shim :)