This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Replace everything before and expanded_dir to get file name #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had an issue in Windows where ```src_path``` contained the full path to the source file, resulting in an incorrect ```file_name```. eg ```src_path``` was ```C:/xampp/htdocs/myproject/bower_components/jquery/dist/jquery.js``` ```file_name``` was ```C:/xampp/htdocs/myproject//dist/jquery.js``` Replacing everything before ```expanded_dir``` fixed the issue...... not sure if that's the best place to do it
|
This case is better handled in #46 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an issue in Windows where
src_pathcontained the full path to the source file, resulting in an incorrectfile_name.eg
src_pathwasC:/xampp/htdocs/myproject/bower_components/jquery/dist/jquery.jsfile_namewasC:/xampp/htdocs/myproject//dist/jquery.jsReplacing everything before
expanded_dirfixed the issue...... not sure if that's the best place to do it