cmake: Replace invalid UTF-8 byte sequence #1271
Conversation
…ompatible pattern
|
@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @billhoffman, @Sukender and @jzakrzewski to be potential reviewers. |
|
hm. I don't know why it was done like that in the first place. I would think there's a regex that makes both of those lines unnecessary? If there is no other feedback after a while I don't see any problem with it. /cc @Sukender |
|
It looks like that second line ( I'd say, remove the Unicode shenanigans entirely: - string(REGEX REPLACE "\\\\\n" "§!§" MAKEFILE_INC_TEXT ${MAKEFILE_INC_TEXT})
+ string(REGEX REPLACE "\\\\\n" "" MAKEFILE_INC_TEXT ${MAKEFILE_INC_TEXT})
string(REGEX REPLACE "([a-zA-Z_][a-zA-Z0-9_]*)[\t ]*=[\t ]*([^\n]*)" "SET(\\1 \\2)" MAKEFILE_INC_TEXT ${MAKEFILE_INC_TEXT})
- string(REPLACE "§!§" "\n" MAKEFILE_INC_TEXT ${MAKEFILE_INC_TEXT}) |
|
I have no clue what the code is doing. I just tried to get rid of the non-UTF-8 char without changing behavior. Feel free to fix this differently. |
@webmaster128 What do you mean? Are you asking me to put up another pull request instead of this one? |
I was just trying to say that I do not feel confident to do greater changes to code I did not write and do not understand what it is doing. So I'd be happy if someone provides a change that superseeds this one by providing a different solution to the same problem. |
A solution that came out of discussion on curl#1271. The strange bytes are used to mark escaped newlines so that they can be converted back after processing. However, text editors and other programs tend to silently change these characters in CMakeLists.txt or complain. This is a cosmetic concern for generated files (which I assume no-one reads), so let's remove it entirely.
|
@webmaster128 In that case, I've opened up #1275 with my proposed solution (removing the strange bytes entirely). |
|
Closing in favour of #1275 |
A solution that came out of discussion on curl#1271. The strange bytes are used to mark escaped newlines so that they can be converted back after processing. However, text editors and other programs tend to silently change these characters in CMakeLists.txt or complain. This is a cosmetic concern for generated files (which I assume no-one reads), so let's remove it entirely.
by and alternative UTF-8 compatible pattern.
Before, the file contained special chars in a different encoding than ASCII or UTF-8 making text editors and Python complain when reading the file. Looks like 7-bit ASCII and UTF-8 are the preferred encodings: https://cmake.org/cmake/help/v3.0/manual/cmake-language.7.html#encoding