Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: fix build with libressl 2.7 #2448

Closed
wants to merge 1 commit into from
Closed

Conversation

ncopa
Copy link
Contributor

@ncopa ncopa commented Apr 2, 2018

LibreSSL 2.7 introduced some of the OpenSSL 1.1 API.

Signed-off-by: Natanael Copa ncopa@alpinelinux.org

@bagder
Copy link
Member

bagder commented Apr 2, 2018

@Sp1l already posted #2447 for the exact same issue!

@bagder
Copy link
Member

bagder commented Apr 3, 2018

This fix uses the wrong syntax on the preprocessor line...

@ncopa
Copy link
Contributor Author

ncopa commented Apr 3, 2018

I can fix that if you want this approach over the #2447. The idea is to check for the needed functions in configure script instead of check for specific versions or openssl/libressl.

LibreSSL 2.7 introduced some of the OpenSSL 1.1 API.

Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
@bagder
Copy link
Member

bagder commented Apr 4, 2018

I prefer a fix that doesn't require a configure change, since we have users building with several other build systems as well., so maybe the #2447 take is then better?

@ncopa
Copy link
Contributor Author

ncopa commented Apr 4, 2018

I think that it is generally a better approach to check for the existence in the configure script (or build system) because then it does not matter what openssl implementation you use or what version it is. It also fixes the problem when a future version of libressl implements a function which is currently not implemented.

But I understand that this may require some major changes and that it is a significant cost to do this and test it properly on multiple build systems. I'm ok with #2447 too. Its up to you.

@bagder bagder closed this in 7c90c93 Apr 4, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

2 participants