Adds support for channel binding for http-SSPI-Negotiate. #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgeok
force-pushed
the
negotiate-sspi-https-401
branch
2 times, most recently
from
189159d
to
4516e49
Compare
georgeok
force-pushed
the
negotiate-sspi-https-401
branch
from
4516e49
to
e995929
Compare
|
@MarcelRaad Since you've seen the same patch for NTLM, could you please help me out with this PR? One of the tests is failing in |
MarcelRaad
reviewed
Jan 31, 2019
lib/urldata.h
Outdated
| @@ -980,6 +983,9 @@ struct connectdata { | |||
| void *seek_client; /* pointer to pass to the seek() above */ | |||
|
|
|||
| /*************** Request - specific items ************/ | |||
| #ifdef SECPKG_ATTR_ENDPOINT_BINDINGS | |||
There was a problem hiding this comment.
Probably also needs USE_WINDOWS_SSPI like in the other conditions?
There was a problem hiding this comment.
Thanks for the feedback. Code updated!
|
Yes, looks unrelated. The code changes look good to me too, |
MarcelRaad
approved these changes
Jan 31, 2019
|
Testing right now. I don't expect any problems, so if there are no objections, I'll merge this later today. |
|
Thank you very much! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add support for Secure Channel binding when negotiate authentication is used. The problem to solve is that by default IIS accepts channel binding and curl doesn't utilise them. The result was a 401 response. Scope affects only the Schannel(winssl)-SSPI combination.