Fix: use proper content types for uploads

packages/cypress-cloud/lib/artifacts.ts

@@ -3,7 +3,7 @@ import { ScreenshotArtifact, ScreenshotUploadInstruction } from "../types";
 import { updateInstanceStdout } from "./api";
 import { safe } from "./lang";
 import { warn } from "./log";
-import { uploadFile } from "./upload";
+import { uploadImage, uploadVideo } from "./upload";
 const debug = Debug("currents:artifacts");
 interface UploadArtifacts {
   videoPath: string | null;
@@ -35,11 +35,9 @@ export async function uploadArtifacts({
   // upload video
   if (videoUploadUrl && videoPath) {
     await safe(
-      uploadFile,
-      // () => info("- Failed Uploading", red(videoPath)),
-      // () => info("- Done Uploading", cyan(videoPath))
-      () => {},
-      () => {}
+      uploadVideo,
+      (e) => debug("failed uploading video %s. Error: %o", videoPath, e),
+      () => debug("success uploading", videoPath)
     )(videoPath, videoUploadUrl);
   }
   // upload screenshots
@@ -59,11 +57,14 @@ export async function uploadArtifacts({
           return Promise.resolve();
         }
         return safe(
-          uploadFile,
-          // () => warn("- Failed Uploading", red(screenshot.path)),
-          // () => info("- Done Uploading", cyan(screenshot.path))
-          () => {},
-          () => {}
+          uploadImage,
+          (e) =>
+            debug(
+              "failed uploading screenshot %s. Error: %o",
+              screenshot.path,
+              e
+            ),
+          () => debug("success uploading", screenshot.path)
         )(screenshot.path, url);
       })
     );

packages/cypress-cloud/lib/httpClient/httpClient.ts

@@ -31,14 +31,14 @@ export function getClient() {
     const req = {
       ...config,
       headers: {
+        "Content-Type": "application/json",
         ...config.headers,
 
         // @ts-ignore
         "x-cypress-request-attempt": config["axios-retry"]?.retryCount ?? 0,
         "x-cypress-run-id": _runId,
         "x-cypress-version": _cypressVersion,
         "x-ccy-version": _currentsVersion ?? "0.0.0",
-        "Content-Type": "application/json",
       },
     };
     debug("network request: %o", req);

packages/cypress-cloud/lib/lang.ts

@@ -1,7 +1,7 @@
 export const safe =
   <T extends any[], R extends any>(
     fn: (...args: T) => Promise<R>,
-    ifFaled: () => any,
+    ifFaled: (e: unknown) => any,
     ifSucceed: () => any
   ) =>
   async (...args: T) => {
@@ -10,6 +10,6 @@ export const safe =
       ifSucceed();
       return r;
     } catch (e) {
-      ifFaled();
+      ifFaled(e);
     }
   };

packages/cypress-cloud/lib/upload.ts

@@ -4,12 +4,24 @@ import { makeRequest } from "./httpClient";
 const readFile = fs.promises.readFile;
 const debug = Debug("currents:upload");
 
-export async function uploadFile(file: string, url: string) {
+export function uploadVideo(file: string, url: string) {
+  return uploadFile(file, url, "application/octet-stream");
+}
+
+export function uploadImage(file: string, url: string) {
+  return uploadFile(file, url, "image/png");
+}
+
+type UploadTypes = "application/octet-stream" | "image/png" | "plain/text";
+async function uploadFile(file: string, url: string, type: UploadTypes) {
   debug('uploading file "%s" to "%s"', file, url);
   const f = await readFile(file);
   await makeRequest({
     url,
     method: "PUT",
     data: f,
+    headers: {
+      "Content-Type": type,
+    },
   });
 }