Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address resolvers #18

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Address resolvers #18

merged 4 commits into from
Jan 1, 2024

Conversation

NotNite
Copy link
Contributor

@NotNite NotNite commented Jan 1, 2024

Heya, first time contributing to a C++ project so let me know if I fucked something up. This PR adds a Lua API to resolve strings in the Address field:

regenny:add_address_resolver(function(str)
  if str == "test" then
    return 0x188279445F0 -- Hardcoded example for now
  end
end)

This is the one big feature I'm missing to be able to switch from ReClass.NET (we have a plugin that does similar in the FFXIV community). The idea I have is to plug our class data into ReGenny to then have it automatically resolve a singleton name to its instance in memory.

In order to build ReGenny I had to update vcpkg, as package URLs no longer existed. I had to change a few includes but everything seems well. I hope this isn't an issue!

@praydog
Copy link
Collaborator

praydog commented Jan 1, 2024

Not seeing any issues with the code at first glance, I'll wait for @cursey's thoughts on this.

@NotNite
Copy link
Contributor Author

NotNite commented Jan 1, 2024

Thanks! I'm currently using it over in https://github.com/NotNite/csgenny and it seems to work OK. Will comment if I find any issues.

Copy link
Owner

@cursey cursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cursey cursey merged commit 0fe8a34 into cursey:master Jan 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants