🛤 Track myst-cli v1.1.8 #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwkoch
reviewed
Aug 11, 2023
| ); | ||
| apiFrontmatter.authors = apiFrontmatter.authors.map((author: Author) => { | ||
| const resolvedAuthor = resolveAffiliations(session, author); | ||
| delete resolvedAuthor.id; |
There was a problem hiding this comment.
The changes in this file back out new additions from the updated affiliations in myst-frontmatter. We need to take a step where we reconcile affiliations in the API / CLI store with the new Affiliations object introduced here: jupyter-book/mystmd#535
Until then, though, this keeps things simple going between API affiliations and MyST frontmatter. Affiliations come through as simple strings still, and those are still handled nicely by the updated myst-frontmatter validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.