Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having global Head alters TopBar style #31

Closed
sttic opened this issue Sep 8, 2020 · 0 comments · Fixed by #36
Closed

Having global Head alters TopBar style #31

sttic opened this issue Sep 8, 2020 · 0 comments · Fixed by #36
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sttic
Copy link
Contributor

sttic commented Sep 8, 2020

It seems like having global Head (in _app) alters the classes/styling applied to TopBar components and potentially more.

It was introduced in 0718853 and the most obvious effect is the Social icons becoming smaller. A new class is being applied to it that overrides the width that was previously set.

Edit: I'm not exactly sure but I feel like it's something to do with trying to set the fontawesome width with emotion/styled instead of using its props. Idk why the issue didn't appear earlier though 🤷

@sttic sttic added the bug Something isn't working label Sep 8, 2020
@sttic sttic added this to the Landing Page milestone Sep 8, 2020
@sttic sttic self-assigned this Sep 11, 2020
sttic added a commit that referenced this issue Sep 11, 2020
@sttic sttic closed this as completed in #36 Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant