fix: tuist users not able to install CIO iOS SDK SPM manifest issue #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #791 +/- ##
==========================================
+ Coverage 63.26% 63.29% +0.02%
==========================================
Files 140 140
Lines 3999 3999
==========================================
+ Hits 2530 2531 +1
+ Misses 1469 1468 -1 ☔ View full report in Codecov by Sentry. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2024
## [3.3.3](3.3.2...3.3.3) (2024-08-08) ### Bug Fixes * tuist users not able to install CIO iOS SDK SPM manifest issue ([#791](#791)) ([cd1346a](cd1346a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #790
Problem
iOS developers who want to use tools such as Tuist to generate xcode projects are currently experiencing an error when resolving the CIO iOS SDK via SPM.
See this PR for the full details of the problem and solution.
Solution
In order for customers to be able to install the iOS SDK via tuist, the iOS SDK's SPM manifest file must point to the correct version of
CioAnalyticsthat includes the bug fix.After this PR gets deployed, customers should be able to install the iOS SDK via tuist on the latest version.
Testing
Installed this git branch in SPM and Cocoapods sample apps. Verified that the correct source code was downloaded and that the apps compile successfully.
I am also going to run the sample apps quick that are built in this PR to verify that CDP API calls work as expected.