Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Copy .rubocop.yml into sandbox #55

Closed
wants to merge 1 commit into from
Closed

Copy .rubocop.yml into sandbox #55

wants to merge 1 commit into from

Conversation

jeremyolliver
Copy link

Similar to the copying of .cane file, this allows customizing the rubocop ruby style checking rules.

At present, the default rubocop rules don't exclude vendor/bundle which means when running strainer on my cookbook repo on travis-ci (and presumably other CI's), rubocop is checking all gems installed from the Gemfile. I'll see about proposing changes to rubocops defaults, but aside from that it would be preferable to also copy across any other customizations

Similar to the copying of `.cane` file, this allows customizing the rubocop ruby style checking rules.

At present, the default rubocop rules don't exclude `vendor/bundle` which means when running on travis-ci (and presumably other CI's), rubocop is checking all gems installed from the Gemfile.
I'll see about proposing changes to rubocops defaults, but aside from that it would be preferable to also copy across any other customizations
@sethvargo
Copy link
Contributor

@jeremyolliver are you operating on a single cookbook or a chef-repo?

@jeremyolliver
Copy link
Author

This is operating on a single cookbook repo

@sethvargo
Copy link
Contributor

@jeremyolliver I'm trying to move people away from Strainer and into a single Rakefile for individual cookbooks. Please see the Jenkins cookbook for an example.

@sethvargo sethvargo closed this Feb 10, 2014
@jeremyolliver
Copy link
Author

No worries. I'd setup my cookbook using the template provided by https://github.com/paulczar/meez which sets things up via strainer. I'll look at migrating to another solution

@arr-dev
Copy link

arr-dev commented Apr 3, 2014

Why wasn't this merged? I am using it with chef-repo and it would really be useful.

@sethvargo
Copy link
Contributor

@soul-rebel please see my previous comment from 2 months ago.

@arr-dev
Copy link

arr-dev commented Apr 3, 2014

I did and i looked at the changes in jenkins but i am not sure i understand. You recommend against using strainer at all?

@jeremyolliver
Copy link
Author

@soul-rebel In terms of managing cookbooks, you can either have one git repo with cookbooks/* or a multiple git repos, one for each cookbook, each with independent tests. Seth is saying that strainer is a tool aimed at the first solution, and discouraged/unsupported for the second.

@arr-dev
Copy link

arr-dev commented Apr 4, 2014

Yes, as I said, I am using it with chef-repo layout.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants