Increase the rate of allowed requests #1969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the amount of requests that an "unauthenticated" user can perform, to prevent throttling errors when using the CLI.
Motivation and context
Hitting the /login endpoint from an unauthenticated user can trigger throttling. While throttling should be kept, as it is good practice, the rate can be increased as the user may have valid authentication. A reasonable level of 100 requests/minute should be enough to enforce good practices while preventing headaches for users trying to automate tasks with the CLI.
(This rate was chosen to be similar to the rate limiting docs for Laravel)
How has this been tested?
Manually.
Checklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.