Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto annotation doc ##2843 #2847

Merged
merged 9 commits into from
Feb 26, 2021

Conversation

mingxin-zheng
Copy link
Contributor

installation_automatic_annotation guide needs to update to reflect the path change

Change the mounting volume for nuctl command from pwd/serverless/openvino/common to pwd/serverless/common

Motivation and context

nuctl complains it can't find python3 if I strictly follow the steps in guideline

How has this been tested?

Tested in the fresh ubuntu 18.04 system

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic
Copy link
Contributor

@waterfall414 , thanks for the PR. Could you please take the latest develop branch and apply your changes? For now we have several conflicts in CHANGELOG.md

@mingxin-zheng
Copy link
Contributor Author

Hi @nmanovic , can you please review the updated PR? I am not experienced at the PR and hope I got it right this time.

@coveralls
Copy link

coveralls commented Feb 25, 2021

Coverage Status

Coverage increased (+0.03%) to 71.041% when pulling 15f6242 on waterfall414:fix-auto-annotation-doc into 1e33901 on openvinotoolkit:develop.

CHANGELOG.md Outdated
@@ -104,6 +105,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Extra shapes are drawn after Esc, or G pressed while drawing a region in grouping (<https://github.com/openvinotoolkit/cvat/pull/2507>)
- Reset state (reviews, issues) after logout or changing a job (<https://github.com/openvinotoolkit/cvat/pull/2525>)
- TypeError: Cannot read property 'id' of undefined when updating a task (<https://github.com/openvinotoolkit/cvat/pull/2544>)
- Cannot find Python when deploying models through nuclio if steps are strictly followed in Installation_Automatic_Annotation.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove one line. I can see the same statement several times in CHANGELOG.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just edited it in github web-client. Did it remove the duplicate?

CHANGELOG.md Outdated Show resolved Hide resolved
@nmanovic nmanovic merged commit 45a0530 into cvat-ai:develop Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants