Manifest fixes #3146
Merged
Manifest fixes #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Marishka17 , could you please add a line into CHANGELOG.md? |
azhavoro
previously approved these changes
May 4, 2021
nmanovic
reviewed
May 4, 2021
| from utils.dataset_manifest import ImageManifestManager, VideoManifestManager | ||
|
|
||
| def migrate_data(apps, shema_editor): | ||
| def get_logger(): | ||
| migration = os.path.basename(__file__).split(".")[0] |
There was a problem hiding this comment.
Does splitext work here? But I'm fine with the solution as well.
nmanovic
reviewed
May 4, 2021
| def get_logger(): | ||
| migration = os.path.basename(__file__).split(".")[0] | ||
| logger = logging.getLogger(name=migration) | ||
| logger.setLevel(logging.INFO) |
There was a problem hiding this comment.
We have a special file with log configs. Do you think we can put the code into https://github.com/openvinotoolkit/cvat/blob/develop/cvat/apps/engine/log.py?
nmanovic
reviewed
May 4, 2021
nmanovic
reviewed
May 4, 2021
nmanovic
reviewed
May 4, 2021
|
@Marishka17 , I believe the PR is good. It is a good idea to use logging inside some migrations. Better to move the initialization code into a common place. Please fix and after that I'm OK with the PR. Great job! |
|
I will merge the PR now to unblock release of CVAT 1.4.0. Please prepare a separate PR with improved logging. |
nmanovic
approved these changes
May 4, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolves #3119
forceflag for preparing video metaHow has this been tested?
In development environment, docker
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example below)