Fixed cropping polygon in some corner cases #3184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
commented
May 12, 2021
Comment on lines
+153
to
+154
| (p1.x === p2.x || Math.sign(resultPoints[0] - resultPoints[2]) !== Math.sign(p1.x - p2.x)) | ||
| && (p1.y === p2.y || Math.sign(resultPoints[1] - resultPoints[3]) !== Math.sign(p1.y - p2.y)) |
There was a problem hiding this comment.
The core change to fix (others are to satisfy eslint, minor refactoring, and some minor bug fixes).
As I understand the issue was following:
After the first (Horizontal) crop p1.x in a corner case could be equal to p2.x).
The same if we reverse crop order (first is Vertical), then p1.y in a corner case could be equal to p2.y.
In these corner cases the condition is false and we do not reverse points when it is actually necessary.
bsekachev
changed the title
Sure. A test will be prepared. |
bsekachev
commented
May 12, 2021
Comment on lines
+248
to
+249
| const dx = offsetCoords[0] ** 2; | ||
| const dy = offsetCoords[1] ** 2; |
There was a problem hiding this comment.
Conflict between prettier and eslint.
There were suggestion to split to several lines:
https://github.com/prettier/eslint-config-prettier#no-mixed-operators
azhavoro
approved these changes
May 13, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Resolved #3178
Hi @dvkruchinin
A test for this case would be good.
How has this been tested?
Manual testing
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.