Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project import simple implementation #3790

Merged
merged 73 commits into from
Dec 17, 2021
Merged

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Oct 12, 2021

Motivation and context

This PR provides the whole dataset (data and annotation) import to the project function. In this iteration splitting data to the task just made by subsets and will be improved in future releases.

Resolves #2331, #1768

How has this been tested?

TODO Checklist

  • Tracks support
  • All formats import support
  • Import status in UI

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ActiveChooN ActiveChooN marked this pull request as ready for review October 28, 2021 10:57
@bsekachev
Copy link
Member

Could you please resolve conflict?

@bsekachev
Copy link
Member

Subset "default" was created when import a dataset with not specified subset, then I exported the project and tried to import it again:

image

Probably not related with this PR, but if I reopen dataset export modal before the previous export finished, I see infinite scroolling. If it is easy to fix, maybe fix it? If not, I can submit an issue.
image

bsekachev
bsekachev previously approved these changes Dec 14, 2021
@bsekachev
Copy link
Member

@ActiveChooN Please, take a look at tests

@ActiveChooN
Copy link
Contributor Author

@ActiveChooN Please, take a look at tests

@bsekachev, fixed

bsekachev
bsekachev previously approved these changes Dec 14, 2021
@bsekachev
Copy link
Member

Could you update cvat-ui version?

@ActiveChooN
Copy link
Contributor Author

Could you update cvat-ui version?

Sure

@nmanovic
Copy link
Contributor

@ActiveChooN , @bsekachev , I'm going to merge the patch today if I don't find any problems.

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 579bfb3 into develop Dec 17, 2021
@nmanovic nmanovic deleted the dk/project-import-prototype branch December 17, 2021 12:39
@ActiveChooN
Copy link
Contributor Author

@aschernov, could you please update the documentation?
@dvkruchinin, could you please prepare UI tests?

@dvkruchinin
Copy link
Contributor

@ActiveChooN

could you please prepare UI tests?

Sure. A test will be prepared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Labels are not imported from yolo datasets Import labels when creating task
5 participants