Fixed labels order #3987
Merged
Fixed labels order #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmanovic
reviewed
Dec 6, 2021
cvat/apps/engine/serializers.py
Outdated
| @@ -79,6 +79,7 @@ class LabelSerializer(serializers.ModelSerializer): | |||
| class Meta: | |||
| model = models.Label | |||
| fields = ('id', 'name', 'color', 'attributes', 'deleted') | |||
| ordering = ['-id'] | |||
There was a problem hiding this comment.
Could you please add a link on documentation about the field? I can see such parameter for Django Models: https://docs.djangoproject.com/en/3.2/ref/models/options/#ordering
There was a problem hiding this comment.
Or may be on the DRF source code. Because in IAM PR I deleted all such fields.
There was a problem hiding this comment.
Could not find any reference. So, moved to custom prefetching of related fields.
nmanovic
reviewed
Dec 8, 2021
nmanovic
approved these changes
Dec 8, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
External bug report
How has this been tested?
No tests, due to no issue reproduction on development setup.
Checklist
developbranch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have linked related issues (read github docs)- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.