-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make user-data-permission-fix optional #3994
Make user-data-permission-fix optional #3994
Conversation
Maybe a better solution would be to add |
@azhavoro , @ActiveChooN , could you please look? |
If this fix can be applied in the build stage it looks like a better solution. |
@azhavoro , could you please review and share your opinion? Should we merge the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nerdinand , thanks for the contribution.
Motivation and context
Deploying CVAT to OpenShift (see also #3992), we've run into problems with the
user-data-permission-fix
initContainer. OpenShift seems to be stricter in what you can do permission-wise. To mitigate this, we propose making the permission fix optional. Along with addingRUN /bin/chmod -R 777 ${HOME}
to the Dockerfile, this works for us.How has this been tested?
Helm chart tested manually
Checklist
develop
branch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.