fix build dependencies for Siammask #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upstream SiamMask/requirements.txt is outdated and unmaintained
|
@VRichardJP , thanks for the contribution. Is it ready for review? |
|
@azhavoro , could you please test the PR? |
|
@nmanovic I think it is good to go |
azhavoro
requested changes
Mar 28, 2022
There was a problem hiding this comment.
@VRichardJP Hello, LGTM, but could you please add a note to the CHANGELOG.md?
azhavoro
previously approved these changes
Mar 30, 2022
nmanovic
approved these changes
Mar 30, 2022
Nithin745
pushed a commit
to Nithin745/cvat-fork
that referenced
this pull request
May 27, 2022
Co-authored-by: Vincent Richard <richard-v@macnica.co.jp> Co-authored-by: Andrey Zhavoronkov <andrey.zhavoronkov@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream SiamMask/requirements.txt is outdated and unmaintained
Motivation and context
see #4475
How has this been tested?
The following commands could successfully build and deploy the network on my machine:
./serverless/deploy_cpu.sh serverless/pytorch/foolwood/siammask/nuclio./serverless/deploy_gpu.sh serverless/pytorch/foolwood/siammask/nuclioI could run the original SiamMask demo using the same changes: https://github.com/foolwood/SiamMask#demo
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.