REST API tests: project accessibility #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizov-kirill
suggested changes
Mar 23, 2022
There was a problem hiding this comment.
Use the pull requests template for future requests.
If you are currently continue working on pull request, then for reviewers convenience and for reducing the number of workflows in GitHub Actions. you can add [WIP] in the title of pull requests.
sizov-kirill
suggested changes
Mar 25, 2022
Co-authored-by: Kirill Sizov <kirill.sizov@intel.com>
Co-authored-by: Kirill Sizov <kirill.sizov@intel.com>
…tProject minor issues
tests/rest_api/test_projects.py
Outdated
Comment on lines
199
to
200
| # [organization] Member of organization that has role supervisor, maintainer or owner can create a project | ||
| # (POST /projects/) |
There was a problem hiding this comment.
Please, leave a comment for tests in case when it's really necessary. For example, in this case I think we don't need to mention (POST /projects) because this TestPostProject test class. And developers can easy understand what this test really do from the name of test function.
nmanovic
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REST API, check if admin can see any project even he has no ownerships for this project