Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: Unable to upload annotations #4459 #4513

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Conversation

k1won
Copy link
Contributor

@k1won k1won commented Mar 24, 2022

Motivation and context

Resolves #4459

How has this been tested?

Manual test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

@k1won k1won requested a review from nmanovic as a code owner March 24, 2022 15:40
@nmanovic nmanovic requested a review from klakhov March 24, 2022 19:37
@nmanovic
Copy link
Contributor

@klakhov , could you please look?

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution! I've tried this patch and it fixes annotations upload to Task and Job.

But while investigating permissions issue, I've found one more problem with Task data upload: upload action was for Task data was renamed from append_tus_chunk to append_data_chunk. So could you change this permission too (lines 654-655)?

cvat/apps/iam/permissions.py Show resolved Hide resolved
cvat/apps/iam/permissions.py Show resolved Hide resolved
@k1won k1won requested a review from klakhov March 25, 2022 09:18
@nmanovic
Copy link
Contributor

@k1won , great contribution once again!

@nmanovic nmanovic merged commit 449ae0c into cvat-ai:develop Mar 25, 2022
@k1won k1won deleted the br_to_fix branch March 25, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to upload annotations
3 participants