Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Open3D to 0.11.2 #4639

Merged
merged 2 commits into from
May 17, 2022
Merged

Revert Open3D to 0.11.2 #4639

merged 2 commits into from
May 17, 2022

Conversation

ngaloppo
Copy link
Contributor

@ngaloppo ngaloppo commented May 16, 2022

Motivation and context

This change fixes a dependency conflict that causes a very old version
of Jinja2 to be installed (see #4618). Open3D is only used for PCD
conversion, so this reverting to an older version is acceptable.

This is a temporary workaround. As a future update we'd like to get rid
of the Open3D dependency, since it pulls in a bunch of unnecessary
dependencies. Also, we'd like to make python dependency resolution more
robust by pinning all (recursive) dependencies to specific versions with
a tool like pip-tools or poetry.

Fixes #4618.

How has this been tested?

Not tested yet. Will rely on CI to test.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2022 Intel Corporation
#
# SPDX-License-Identifier: MIT

This change fixes a dependency conflict that causes a very old version
of Jinja2 to be installed (see #4618). Open3D is only used for PCD
conversion, so this reverting to an older version is acceptable.

This is a temporary workaround. As a future update we'd like to get rid
of the Open3D dependency, since it pulls in a bunch of unnecessary
dependencies. Also, we'd like to make python dependency resolution more
robust by pinning all (recursive) dependencies to specific versions with
a tool like pip-tools or poetry.
@nmanovic
Copy link
Contributor

@ngaloppo , it looks good! Usually we add a line into CHANGELOG.md to track changes: https://github.com/openvinotoolkit/cvat/blob/develop/CHANGELOG.md

@ngaloppo ngaloppo self-assigned this May 16, 2022
@ngaloppo ngaloppo requested a review from nmanovic May 16, 2022 20:45
@ngaloppo ngaloppo removed their assignment May 16, 2022
@ngaloppo ngaloppo requested a review from spradeep28 May 17, 2022 13:43
Copy link

@spradeep28 spradeep28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looking good

@ngaloppo ngaloppo merged commit d7560bb into develop May 17, 2022
@kresimirfijacko
Copy link

how is it possible to install open3d==0.11.2 when it is neccessary to use python3.9 (as stated in documentation for developing locally) ?
the thing is - output of pip install gives:

pip install open3d==0.11.2

ERROR: Could not find a version that satisfies the requirement open3d==0.11.2 (from versions: 0.14.1, 0.15.2)
ERROR: No matching distribution found for open3d==0.11.2

@bely66 bely66 mentioned this pull request Jun 7, 2022
2 tasks
nmanovic added a commit that referenced this pull request Aug 19, 2022
…ild"

This reverts commit d7560bb, reversing
changes made to ba4175b.
@bsekachev bsekachev deleted the ncgalopp/fix-build branch August 31, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants