Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some documentation added for skeletons feature #4925

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Conversation

bsekachev
Copy link
Member

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev added the documentation Documentation should be updated label Sep 9, 2022
@bsekachev bsekachev changed the title [WIP] Some documentation added for skeletons feature Some documentation added for skeletons feature Sep 9, 2022
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somebody should redraw in the future: site/content/en/images/image-skeleton-configurator-overview.jpg

Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will ask Andrey's team to improve images and Maxime, to improve the content itself.

@nmanovic nmanovic merged commit f9a2e27 into develop Sep 9, 2022
@bsekachev bsekachev deleted the bs/skeletons_docs branch September 12, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation should be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants