Django social account sso #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddx-day , thanks for the contribution! We are working on the improving authentication flow right now. You contribution is on time. Please give us some time to review your code. It can take a while because we just investigating how we want to add it. There are many possibilities. Are you from a company which uses CVAT internally? I would love to meet and collaborate. |
|
Hi,
Yes. We use CVAT along with several other labeling tools internally, and have found it useful at least partly because we are easily able to add features. I CCed the lead from the machine learning team.
Best,
Melanie
From: Nikita Manovich ***@***.***>
Sent: Friday, October 7, 2022 5:27 AM
To: opencv/cvat ***@***.***>
Cc: Melanie Day ***@***.***>; Mention ***@***.***>
Subject: Re: [opencv/cvat] Django social account sso (PR #5059)
@ddx-day<https://github.com/ddx-day> , thanks for the contribution! We are working on the improving authentication flow right now. You contribution is on time. Please give us some time to review your code. It can take a while because we just investigating how we want to add it. There are many possibilities.
Are you from a company which uses CVAT internally? I would love to meet and collaborate.
—
Reply to this email directly, view it on GitHub<#5059 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A3OVZ4LIZ3FIGGQ7KMV74MLWCAJK3ANCNFSM6AAAAAAQ7RHSAA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[EXTERNAL]
|
added 2 commits
October 7, 2022 05:39
…y/cvat into django-social-account-sso
ddx-day
commented
Oct 7, 2022
…require in legacy code
Marishka17
reviewed
Jan 11, 2023
Marishka17
changed the title
|
@nmanovic, PR is ready. |
Marishka17
changed the title
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this pull request
Jul 1, 2023
Issue: cvat-ai#1217 Currently there are a few proposals for SSO authentication to bypass the current user/password login on the UI. By using Django social accounts it is also possible to use SSO on the API, retrieving the security token by passing the code from the OAuth2 workflow. This is an example using Amazon Cognito, but any other social account could also be added. ### Motivation and context Currently CVAT has no functionality to log in with SSO. Other current proposals bypass the current Django framework to add SSO in the UI only, but still use username and password for the API. Using Django social accounts integrates SSO with the API as well, allowing it to be used as an alternative to the username and password, but can also be used together with other SSO frameworks that are UI only. ### How has this been tested? Unit tests for SSO manager in cvat-core and integration test with cvat-sdk for /auth/cognito endpoint. ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable by a reason then ~~explicitly strikethrough~~ the whole line. If you don't do that github will show an incorrect process for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [ ] I have added a description of my changes into [CHANGELOG](https://github.com/cvat-ai/cvat/blob/develop/CHANGELOG.md) file - [x] I have updated the [documentation]( https://github.com/cvat-ai/cvat/blob/develop/README.md#documentation) accordingly - [x] I have added tests to cover my changes - [x] I have linked related issues ([read github docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [ ] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. Co-authored-by: Melanie Day <mday@EYEDIAGNOSIS.local> Co-authored-by: Maria Khrustaleva <maria@cvat.ai> Co-authored-by: Nikita Manovich <nikita@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1217
Currently there are a few proposals for SSO authentication to bypass the current user/password login on the UI. By using Django social accounts it is also possible to use SSO on the API, retrieving the security token by passing the code from the OAuth2 workflow. This is an example using Amazon Cognito, but any other social account could also be added.
Motivation and context
Currently CVAT has no functionality to log in with SSO. Other current proposals bypass the current Django framework to add SSO in the UI only, but still use username and password for the API. Using Django social accounts integrates SSO with the API as well, allowing it to be used as an alternative to the username and password, but can also be used together with other SSO frameworks that are UI only.
How has this been tested?
Unit tests for SSO manager in cvat-core and integration test with cvat-sdk for /auth/cognito endpoint.
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.