Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported type for all labels #5273

Merged
merged 10 commits into from
Nov 14, 2022
Merged

Supported type for all labels #5273

merged 10 commits into from
Nov 14, 2022

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Nov 10, 2022

Motivation and context

image

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@bsekachev bsekachev added the enhancement New feature or request label Nov 10, 2022
@bsekachev bsekachev changed the title [WIP] Supported type for all labels Supported type for all labels Nov 11, 2022
@bsekachev bsekachev requested review from klakhov and nmanovic and removed request for nmanovic November 11, 2022 09:26
@bsekachev
Copy link
Member Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

✔️ All checks completed successfully
📄 See logs here

Copy link
Contributor

@klakhov klakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch works for me.
What do you think about adding appropriate enum for label types? It doesn't feel right to use consts like 'tag' or 'any'.

@bsekachev
Copy link
Member Author

bsekachev commented Nov 11, 2022

Patch works for me. What do you think about adding appropriate enum for label types? It doesn't feel right to use consts like 'tag' or 'any'.

I think it makes sense..
Not it is described like type = 'rectangle' | 'polygon' | ...

@bsekachev bsekachev merged commit 7265553 into develop Nov 14, 2022
@bsekachev bsekachev deleted the bs/supported_type branch November 21, 2022 08:07
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants