Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix cvat version string #5721

Closed
wants to merge 3 commits into from
Closed

Conversation

wang-tf
Copy link

@wang-tf wang-tf commented Feb 17, 2023

It will be error if using CVAT_VERSION without 'v'.

Motivation and context

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have added a description of my changes into the CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

It will be error if using CVAT_VERSION without 'v'.
@nmanovic
Copy link
Contributor

@wang-tf , thanks for the contribution. I'm not sure that the change is correct. Could you please check? At least the line below should work with the change:

wget https://github.com/opencv/cvat/archive/refs/tags/v${CVAT_VERSION}.zip

@wang-tf
Copy link
Author

wang-tf commented Feb 22, 2023

Oh, you are right. In my test, adding export CVAT_VERSION="v2.3.0" before docker compose pull can fix this error.

Otherwise, the error will appear like:
ERROR: for cvat_server manifest for cvat/server:2.3.0 not found: manifest unknown: manifest unknown

@zhiltsov-max zhiltsov-max changed the title fix cvat version string [WIP] fix cvat version string Mar 22, 2023
@zhiltsov-max
Copy link
Contributor

Already fixed in #5585. Thank you for your participation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants