Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC2024] fix warped image loading #7583

Merged
merged 5 commits into from
Mar 27, 2024
Merged

[GSoC2024] fix warped image loading #7583

merged 5 commits into from
Mar 27, 2024

Conversation

tahamukhtar20
Copy link
Contributor

@tahamukhtar20 tahamukhtar20 commented Mar 10, 2024

Motivation and context

Fixes: #7394

This PR fixes the issue stated in the above-mentioned issue, the issue was caused when a 90 deg-rotated video was added with "Prefer Zip Chunks" disabled, and the image loaded was warped, which is now fixed using the static cropImage function found in this commit as this was the commit where this issue initially started

How has this been tested?

Added various images to test the bug fix, this did not require any new test cases.

Checklist

  • I submit my changes into the develop branch
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@tahamukhtar20
Copy link
Contributor Author

I didn't post a solution before for review, it skipped my mind that I had to do that, please let me know if there are any issues with this, and I'll reimplement that.
I've already implemented this solution in the PR attached above, here is how I solved it currently, I noticed that this was working fine in v-2.5.1 and not in v-2.6.2 so I checked out the commits in between both versions and identified that the culprit was this piece of cvat-data code change in this commit. Now what I did was identify what was missing here, I noticed that imageBitmap was now being used across the entire application but something was missing that was in the previous PR that wasn't in this. which was that the crop image function's code was completely missing and that was why the issue was happening in the first place. So I added that in the code base in a way that nothing else was affected and tested it out in various environments making sure it worked for all types of images

@tahamukhtar20
Copy link
Contributor Author

@bsekachev Sorry for pinging you like this, I think you should also have a look at this Pull Request as the piece of code that I changed here was directly changed by you a few months back.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #7583 (4a27baa) into develop (5b9ab8e) will decrease coverage by 0.17%.
Report is 46 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7583      +/-   ##
===========================================
- Coverage    83.53%   83.36%   -0.17%     
===========================================
  Files          372      373       +1     
  Lines        39661    39738      +77     
  Branches      3724     3743      +19     
===========================================
- Hits         33130    33128       -2     
- Misses        6531     6610      +79     
Components Coverage Δ
cvat-ui 79.16% <0.00%> (-0.26%) ⬇️
cvat-server 87.24% <ø> (-0.07%) ⬇️

@bsekachev bsekachev removed the request for review from azhavoro March 14, 2024 14:07
@nmanovic
Copy link
Contributor

@SpecLad , could you please help with the review?

@nmanovic nmanovic requested review from SpecLad and klakhov and removed request for bsekachev and SpecLad March 21, 2024 10:40
@klakhov klakhov added the ui/ux label Mar 26, 2024
@bsekachev
Copy link
Member

@tahamukhtar20

Could you please check changelog entry?

scriv create --edit

@tahamukhtar20
Copy link
Contributor Author

@bsekachev added the changelog entry.

@bsekachev
Copy link
Member

Great, thank you for the contribution!

@bsekachev bsekachev merged commit 26750a9 into cvat-ai:develop Mar 27, 2024
32 of 33 checks passed
g-kartik pushed a commit to g-kartik/cvat that referenced this pull request Mar 29, 2024
@cvat-bot cvat-bot bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect display of images extracted from rotated video (no zip chunks)
4 participants