-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC2024] fix warped image loading #7583
Conversation
I didn't post a solution before for review, it skipped my mind that I had to do that, please let me know if there are any issues with this, and I'll reimplement that. |
@bsekachev Sorry for pinging you like this, I think you should also have a look at this Pull Request as the piece of code that I changed here was directly changed by you a few months back. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7583 +/- ##
===========================================
- Coverage 83.53% 83.36% -0.17%
===========================================
Files 372 373 +1
Lines 39661 39738 +77
Branches 3724 3743 +19
===========================================
- Hits 33130 33128 -2
- Misses 6531 6610 +79
|
@SpecLad , could you please help with the review? |
Could you please check changelog entry?
|
@bsekachev added the changelog entry. |
Great, thank you for the contribution! |
Motivation and context
Fixes: #7394
This PR fixes the issue stated in the above-mentioned issue, the issue was caused when a 90 deg-rotated video was added with "Prefer Zip Chunks" disabled, and the image loaded was warped, which is now fixed using the static cropImage function found in this commit as this was the commit where this issue initially started
How has this been tested?
Added various images to test the bug fix, this did not require any new test cases.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.