Use the same algorithm to throttle quality reports as analytics reports #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/check |
|
✔️ All checks completed successfully |
SpecLad
force-pushed
the
throttling-quality-reports
branch
from
6498927
to
c4a7e4b
Compare
See 009f9f8 for more details. This patch extracts the high-level throttling functionality added in that patch and reuses it for quality reports. Note: in that patch I referred to this functionality as debouncing, but throttling seems like a more accurate description. It would be debouncing if the autoupdate job only ran after no updates occurred for a period, which is not how it actually works.
SpecLad
force-pushed
the
throttling-quality-reports
branch
from
c4a7e4b
to
c1ba489
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #7596 +/- ##
===========================================
- Coverage 83.37% 83.37% -0.01%
===========================================
Files 373 373
Lines 39747 39712 -35
Branches 3745 3745
===========================================
- Hits 33141 33109 -32
+ Misses 6606 6603 -3
|
zhiltsov-max
approved these changes
Mar 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
See #7576 for more details. This patch extracts the high-level throttling functionality added in that patch and reuses it for quality reports.
Note: in that patch I referred to this functionality as debouncing, but throttling seems like a more accurate description. It would be debouncing if the autoupdate job only ran after no updates occurred for a period, which is not how it actually works.
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)[ ] I have increased versions of npm packages if it is necessary(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.