[GSoC2024] Added Validations, testcases to Labels Constructor

[mach-12]

1. Added new Label Validation to handle empty label name given to constructor.
2. Fixed existing validation for Duplicate label name to make it more clear.
3. Added tests for both.

Motivation and context

Background

• Mentioned as anui-ux enhancement issue in Labels constructor enhancements #5729, Two problems were raised:
  1. Hint when user tries to add existing label in project is incorrect as the same code validation is triggered in both project and task.
  2. When user enters an empty label name, It is not intuitively clear that the state of the constructor is reset and skeleton is not added.

Fix

1. Tests were written for the desired outcome.
2. Fixed the Unique Label Validation by changing the display message to a generalized one.

4. Added a new Empty Label Validation which stops the form from submitting when label name is empty and displays an error message.

How has this been tested?

• The issue was first triggered locally.
• Test cases were written using Cypress, Here are the screenshots of the same.

Checklist

• I submit my changes into the develop branch
• I have created a changelog fragment
• I have updated the documentation accordingly
• I have added tests to cover my changes
• I have linked related issues (see GitHub docs)
• I have increased versions of npm packages if it is necessary
  (cvat-canvas,
  cvat-core,
  cvat-data and
  cvat-ui)

License

• I submit my code changes under the same MIT License that covers the project.
  Feel free to contact the maintainers if that's a concern.

[mach-12]

hello @bsekachev @azhavoro, requesting a review.
Thanks.

[klakhov]

• Please, update headers with actual year in all the files you've updated
• Add a changelog entry describing your fix

[mach-12]

Thanks @klakhov! Implemented your fixes:

1. Removed custom validation, used 'required' flag.
2. Corrected header.
3. Fixed message in new test.
4. Modified CHANGELOG.md

[klakhov]

@mach-12
It looks after your changes something is wrong with tests. Could you check it?

[mach-12]

On it @klakhov

[klakhov]

@mach-12 , it seems there is one more problem in skeletons_pipeline.js test

[mach-12]

Hello @klakhov, 38ac2cc addresses the in the skeletons_pipeline.js test. It took some time to solve because the error in pipeline was unclear. I was puzzled why adding validation caused a problem, and even more when I found out it was due to a file upload.

Problem Description:

• Prior to the fix, after creating a new Skeleton Label, the addNewSkeletonLabel Cypress test would press the "Continue" button twice within the modal, attempting to close it. Which worked as two presses were equivalent to submitting and then closing the modal.
• However, post-modification, this action caused the Constructor Modal to remain active, which in turn interfered with subsequent file uploads. This interference resulted in a failure to capture the 201 response from taskPost, as there was no required file to passed, leading to a timeout.

Issue and Fix: Pressed the 'Cancel' button.

• Issue
  https://github.com/opencv/cvat/blob/98825a0a120b4026685989f769cfd1becee1d98f/tests/cypress/support/commands.js#L1023-L1028

• Fix

        cy.contains('Continue').scrollIntoView();
        cy.contains('Continue').click();
        cy.contains('Cancel').click();
       }); 
   }); 

Screenshots

1. New Skeleton Label Submission: After the submission, the UI is expected to progress smoothly.
   

2. Constructor Modal Issue: Post-submission, the modal fails to close, causing a disruption in file uploading.
   

3. Task Post Timeout: The taskPost operation is times outs because the Submit & Open action fails to initiate due to missing file upload.
   

[codecov]

Codecov Report

Merging #7627 (af55e15) into develop (f513aa1) will decrease coverage by 0.02%.
Report is 9 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7627      +/-   ##
===========================================
- Coverage    83.47%   83.46%   -0.02%     
===========================================
  Files          373      373              
  Lines        39739    39726      -13     
  Branches      3741     3741              
===========================================
- Hits         33171    33156      -15     
- Misses        6568     6570       +2     

Components	Coverage Δ
cvat-ui	79.27% <ø> (-0.02%)	⬇️
cvat-server	87.32% <100.00%> (-0.01%)	⬇️